Issue 4185011: autotest: Make crash tests resilient to builds with high ambient crash rates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4185011: autotest: Make crash tests resilient to builds with high ambient crash rates (Closed)

Created:
10 years, 1 month ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

autotest: Make crash tests resilient to builds with high ambient crash rates Change-Id: I1d7dadf109f129a087cb50bcc1c452f6d6f7d02f BUG=8415 TEST=Run tests with 10Hz ambient crash rate Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ddcd92d

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -6 lines)			Patch
	M	client/bin/site_crash_test.py	View		4 chunks	+24 lines, -0 lines	0 comments	Download
	M	client/site_tests/logging_UserCrash/logging_UserCrash.py	View		8 chunks	+42 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 1 month ago (2010-10-30 06:27:59 UTC) #2

LGTM w/ nit.  Thanks for fixing this!!!!

http://codereview.chromium.org/4185011/diff/1/3
File client/site_tests/logging_UserCrash/logging_UserCrash.py (right):

http://codereview.chromium.org/4185011/diff/1/3#newcode417
client/site_tests/logging_UserCrash/logging_UserCrash.py:417: 'Timeout waiting
for: ' + to_find + ' in ' +
'Timeout waiting for: %s in %s' % (to_find, blah)

Expand Messages | Collapse Messages