Reduce the number of pylint warnings in gcl.py to make refactoring simpler.

gcl.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
 import getpass
 import os
 import random
 import re
 import string
 import subprocess
 import sys
 import tempfile
 import time
 from third_party import upload
 import urllib2
 
-__pychecker__ = 'unusednames=breakpad'
 import breakpad
-__pychecker__ = ''
 
 # gcl now depends on gclient.
 from scm import SVN
 import gclient_utils
 
 __version__ = '1.2'
 
 
 CODEREVIEW_SETTINGS = {
   # To make gcl send reviews to a server, check in a file named
@@ skipping 626 matching lines @@
 
 def defer_attributes(a, b):
   """Copy attributes from an object (like a function) to another."""
   for x in dir(a):
     if not getattr(b, x, None):
       setattr(b, x, getattr(a, x))
 
 
 def need_change(function):
   """Converts args -> change_info."""
+  # pylint: disable=W0612,W0621
   def hook(args):
     if not len(args) == 1:
       ErrorExit("You need to pass a change list name")
     change_info = ChangeInfo.Load(args[0], GetRepositoryRoot(), True, True)
     return function(change_info)
   defer_attributes(function, hook)
   hook.need_change = True
   hook.no_args = True
   return hook
 
 
 def need_change_and_args(function):
   """Converts args -> change_info."""
+  # pylint: disable=W0612,W0621
   def hook(args):
     if not args:
       ErrorExit("You need to pass a change list name")
     change_info = ChangeInfo.Load(args.pop(0), GetRepositoryRoot(), True, True)
     return function(change_info, args)
   defer_attributes(function, hook)
   hook.need_change = True
   return hook
 
 
 def no_args(function):
   """Make sure no args are passed."""
+  # pylint: disable=W0612,W0621
   def hook(args):
     if args:
       ErrorExit("Doesn't support arguments")
     return function()
   defer_attributes(function, hook)
   hook.no_args = True
   return hook
 
 
 def attrs(**kwargs):
@@ skipping 327 matching lines @@
   new_cl_files = []
   for line in cl_files_text.splitlines():
     if not len(line):
       continue
     if line.startswith("---"):
       break
     status = line[:7]
     filename = line[7:]
     new_cl_files.append((status, filename))
 
-  if (not len(change_info._files)) and (not change_info.issue) and \
-      (not len(new_description) and (not new_cl_files)):
+  if (not len(change_info.GetFiles()) and not change_info.issue and
+      not len(new_description) and not new_cl_files):
     ErrorExit("Empty changelist not saved")
 
   change_info._files = new_cl_files
   change_info.Save()
   if svn_info.get('URL', '').startswith('http:'):
     Warn("WARNING: Creating CL in a read-only checkout.  You will not be "
          "able to commit it!")
 
   print change_info.name + " changelist saved."
   if change_info.MissingTests():
@@ skipping 80 matching lines @@
       print "".join(filename)
   return 0
 
 
 @no_args
 def CMDdeleteempties():
   """Delete all changelists that have no files."""
   print "\n--- Deleting:"
   for cl in GetCLs():
     change_info = ChangeInfo.Load(cl, GetRepositoryRoot(), True, True)
-    if not len(change_info._files):
+    if not len(change_info.GetFiles()):
       print change_info.name
       change_info.Delete()
   return 0
 
 
 @no_args
 def CMDnothave():
   """Lists files unknown to Subversion."""
   for filename in UnknownFiles():
     print "?      " + "".join(filename)
@@ skipping 100 matching lines @@
   return getattr(sys.modules[__name__], 'CMD' + name, None)
 
 
 def GenUsage(command):
   """Modify an OptParse object with the function's documentation."""
   obj = Command(command)
   display = command
   more = getattr(obj, 'usage', '')
   if command == 'help':
     display = '<command>'
-  need_change = ''
+  need_change_val = ''
   if getattr(obj, 'need_change', None):
-    need_change = ' <change_list>'
+    need_change_val = ' <change_list>'
   options = ' [options]'
   if getattr(obj, 'no_args', None):
     options = ''
-  res = 'Usage: gcl %s%s%s %s\n\n' % (display, need_change, options, more)
+  res = 'Usage: gcl %s%s%s %s\n\n' % (display, need_change_val, options, more)
   res += re.sub('\n  ', '\n', obj.__doc__)
   return res
 
 
 def CMDhelp(args):
   """Prints this help or help for the given command."""
   if args and 'CMD' + args[0] in dir(sys.modules[__name__]):
     print GenUsage(args[0])
 
     # These commands defer to external tools so give this info too.
@@ skipping 52 matching lines @@
     if e.code != 500:
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   sys.exit(main(sys.argv[1:]))