Issue 4184008: Reduce the number of pylint warnings in gcl.py to make refactoring simpler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4184008: Reduce the number of pylint warnings in gcl.py to make refactoring simpler. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Reduce the number of pylint warnings in gcl.py to make refactoring simpler. Doing static analysis on the script greatly easy refactoring since it reduces the chances of leaving a typo in rarely executed & untested & untested code. This is in preparation to refactor changelist on-disk format to use json. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64427

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	gcl.py	View		7 chunks	+9 lines, -8 lines	0 comments	Download
	M	pylintrc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages