Issue 4184007: prebuilt.py: fix variant detection regex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4184007: prebuilt.py: fix variant detection regex (Closed)

Created:
10 years, 1 month ago by Olof Johansson

Modified:
9 years, 7 months ago

Reviewers:
davidjames, Elly Fong-Jones

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

prebuilt.py: fix variant detection regex Without this, I get: Traceback (most recent call last): File "./prebuilt.py", line 495, in <module> main() File "./prebuilt.py", line 491, in main git_sync=options.git_sync) File "./prebuilt.py", line 408, in UploadPrebuilt git_file = os.path.join(build_path, DetermineMakeConfFile(board)) File "./prebuilt.py", line 378, in DetermineMakeConfFile raise UnknownBoardFormat('Unknown format: %s' % target) __main__.UnknownBoardFormat: Unknown format: tegra2_seaboard Change-Id: I1d595b7e1c596139acca344f7a145143686dace1 BUG=chromium-os:8388 TEST=./prebuilt.py -p ~/chromiumos -b tegra2_seaboard -u user@workstation:/tmp

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	prebuilt.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Elly Fong-Jones

On 2010/10/29 14:41:59, Olof Johansson wrote: > LGTM.

10 years, 1 month ago (2010-10-29 14:50:05 UTC) #2

kliegs

10 years, 1 month ago (2010-10-29 14:52:25 UTC) #3

LGTM

On Fri, Oct 29, 2010 at 10:50 AM, <ellyjones@chromium.org> wrote:

> On 2010/10/29 14:41:59, Olof Johansson wrote:
>
>
> LGTM.
>
>
> http://codereview.chromium.org/4184007/show
>

Expand Messages | Collapse Messages