Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 4182012: Adds error text for the ERR_NETWORK_ACCESS_DENIED error,... (Closed)

Created:
10 years, 1 month ago by mmenke
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Adds error text for the ERR_NETWORK_ACCESS_DENIED error, which is generally caused by a firewall. Also removes the title strings for proxy and disconnected errors, replacing them with pre-existing generic ones, and sorting them by their new title. This avoids a debug assertion caused by the fact neither title includes the url of the original page. Not much of titles are seen anyways, so not worth the effort of a workaround. BUG=57108 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64786

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -65 lines) Patch
M chrome/app/generated_resources.grd View 1 2 5 chunks +68 lines, -51 lines 0 comments Download
M chrome/renderer/localized_error.cc View 1 3 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mmenke
Note that the ERR_NETWORK_ACCESS_DENIED CL is still under review, just thought I'd get this reviewed ...
10 years, 1 month ago (2010-10-29 18:37:58 UTC) #1
mmenke
On 2010/10/29 18:37:58, Matt Menke wrote: > Note that the ERR_NETWORK_ACCESS_DENIED CL is still under ...
10 years, 1 month ago (2010-10-29 18:39:58 UTC) #2
tony
LGTM http://codereview.chromium.org/4182012/diff/16001/17001 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/4182012/diff/16001/17001#newcode5665 chrome/app/generated_resources.grd:5665: Unable to access your network. The use of ...
10 years, 1 month ago (2010-10-29 18:54:19 UTC) #3
tony
http://codereview.chromium.org/4182012/diff/16001/17001 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/4182012/diff/16001/17001#newcode5665 chrome/app/generated_resources.grd:5665: Unable to access your network. On 2010/10/29 18:54:19, tony ...
10 years, 1 month ago (2010-10-29 18:54:46 UTC) #4
mmenke
10 years, 1 month ago (2010-10-29 18:59:34 UTC) #5
Thanks.

http://codereview.chromium.org/4182012/diff/16001/17001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/4182012/diff/16001/17001#newcode5665
chrome/app/generated_resources.grd:5665: Unable to access your network.
On 2010/10/29 18:54:19, tony wrote:
> The use of 'your' here seems weird.  Maybe just "Uanble to access the
network."?

Now that you mention it, indeed it does.  Change made (both places).

Powered by Google App Engine
This is Rietveld 408576698