Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3256)

Unified Diff: ppapi/tests/test_var_deprecated.cc

Issue 4182010: Use PASS() everywhere in ppapi/tests. (Closed) Base URL: https://ppapi.googlecode.com/svn/trunk/tests
Patch Set: First. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_url_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_var_deprecated.cc
diff --git a/ppapi/tests/test_var_deprecated.cc b/ppapi/tests/test_var_deprecated.cc
index b4bdee9473516dfee212766f62c017fdc0986a58..724e914d74495ee292d6dec12a29c3252b604c65 100644
--- a/ppapi/tests/test_var_deprecated.cc
+++ b/ppapi/tests/test_var_deprecated.cc
@@ -73,7 +73,7 @@ std::string TestVarDeprecated::TestBasicString() {
ASSERT_TRUE(testing_interface_->GetLiveObjectCount(
pp::Module::Get()->pp_module()) == before_object);
- return std::string();
+ PASS();
}
std::string TestVarDeprecated::TestInvalidAndEmpty() {
@@ -101,7 +101,7 @@ std::string TestVarDeprecated::TestInvalidAndEmpty() {
ASSERT_EQ(0, len);
ASSERT_NE(NULL, result);
- return std::string();
+ PASS();
}
std::string TestVarDeprecated::TestInvalidUtf8() {
@@ -111,7 +111,7 @@ std::string TestVarDeprecated::TestInvalidUtf8() {
if (!sjis.is_null())
return "Non-UTF8 string permitted.";
- return "";
+ PASS();
}
std::string TestVarDeprecated::TestNullInputInUtf8Conversion() {
@@ -145,7 +145,7 @@ std::string TestVarDeprecated::TestNullInputInUtf8Conversion() {
return "Expected NULL input to make an empty string Var.";
}
- return "";
+ PASS();
}
std::string TestVarDeprecated::TestValidUtf8() {
@@ -169,7 +169,7 @@ std::string TestVarDeprecated::TestValidUtf8() {
return "String mismatches on conversion back from PP_Var.";
}
- return "";
+ PASS();
}
std::string TestVarDeprecated::TestUtf8WithEmbeddedNulls() {
@@ -193,7 +193,7 @@ std::string TestVarDeprecated::TestUtf8WithEmbeddedNulls() {
return "String mismatches on conversion back from PP_Var.";
}
- return "";
+ PASS();
}
std::string TestVarDeprecated::TestVarToUtf8ForWrongType() {
@@ -247,7 +247,7 @@ std::string TestVarDeprecated::TestVarToUtf8ForWrongType() {
return "Expected NULL on string conversion from Double var.";
}
- return "";
+ PASS();
}
std::string TestVarDeprecated::TestHasPropertyAndMethod() {
@@ -324,6 +324,6 @@ std::string TestVarDeprecated::TestHasPropertyAndMethod() {
ASSERT_TRUE(testing_interface_->GetLiveObjectCount(
pp::Module::Get()->pp_module()) == before_objects);
- return std::string();
+ PASS();
}
« no previous file with comments | « ppapi/tests/test_url_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698