Use PASS() everywhere in ppapi/tests.

ppapi/tests/test_graphics_2d.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_graphics_2d.h"
 
 #include <string.h>
 
 #include "ppapi/c/dev/ppb_testing_dev.h"
 #include "ppapi/c/pp_errors.h"
@@ skipping 215 matching lines @@
   // ReadImageData.
   if (testing_interface_->ReadImageData(image.pp_resource(),
                                         image.pp_resource(),
                                         &zero_zero))
     return "ReadImageData succeeded with a different resource";
   if (testing_interface_->ReadImageData(null_context.pp_resource(),
                                         image.pp_resource(),
                                         &zero_zero))
     return "ReadImageData succeeded with a NULL resource";
 
-  return "";
+  PASS();
 }
 
 std::string TestGraphics2D::TestInvalidSize() {
   pp::Graphics2D a(pp::Size(16, 0), false);
   if (!a.is_null())
     return "0 height accepted";
 
   pp::Graphics2D b(pp::Size(0, 16), false);
   if (!b.is_null())
     return "0 width accepted";
 
   // Need to use the C API since pp::Size prevents negative sizes.
   PP_Size size;
   size.width = 16;
   size.height = -16;
   ASSERT_FALSE(!!graphics_2d_interface_->Create(
       pp::Module::Get()->pp_module(), &size, PP_FALSE));
 
   size.width = -16;
   size.height = 16;
   ASSERT_FALSE(!!graphics_2d_interface_->Create(
       pp::Module::Get()->pp_module(), &size, PP_FALSE));
 
-  return "";
+  PASS();
 }
 
 std::string TestGraphics2D::TestHumongous() {
   pp::Graphics2D a(pp::Size(100000, 100000), false);
   if (!a.is_null())
     return "Humongous device created";
-  return "";
+  PASS();
 }
 
 std::string TestGraphics2D::TestInitToZero() {
   const int w = 15, h = 17;
   pp::Graphics2D dc(pp::Size(w, h), false);
   if (dc.is_null())
     return "Failure creating a boring device";
 
   // Make an image with nonzero data in it (so we can test that zeros were
   // actually read versus ReadImageData being a NOP).
   pp::ImageData image(PP_IMAGEDATAFORMAT_BGRA_PREMUL, pp::Size(w, h), true);
   if (image.is_null())
     return "Failure to allocate an image";
   memset(image.data(), 0xFF, image.stride() * image.size().height() * 4);
 
   // Read out the initial data from the device & check.
   if (!ReadImageData(dc, &image, pp::Point(0, 0)))
     return "Couldn't read image data";
   if (!IsSquareInImage(image, 0, pp::Rect(0, 0, w, h), 0))
     return "Got a nonzero pixel";
 
-  return "";
+  PASS();
 }
 
 std::string TestGraphics2D::TestDescribe() {
   const int w = 15, h = 17;
   pp::Graphics2D dc(pp::Size(w, h), false);
   if (dc.is_null())
     return "Failure creating a boring device";
 
   PP_Size size;
   size.width = -1;
   size.height = -1;
   PP_Bool is_always_opaque = PP_TRUE;
   if (!graphics_2d_interface_->Describe(dc.pp_resource(), &size,
                                         &is_always_opaque))
     return "Describe failed";
   if (size.width != w || size.height != h || is_always_opaque != PP_FALSE)
     return "Mismatch of data.";
 
-  return "";
+  PASS();
 }
 
 std::string TestGraphics2D::TestPaint() {
   const int w = 15, h = 17;
   pp::Graphics2D dc(pp::Size(w, h), false);
   if (dc.is_null())
     return "Failure creating a boring device";
 
   // Make sure the device background is 0.
   if (!IsDCUniformColor(dc, 0))
@@ skipping 57 matching lines @@
   const int subset_x = 2, subset_y = 1;
   *subset.GetAddr32(pp::Point(subset_x, subset_y)) = subset_color;
   dc.PaintImageData(subset, pp::Point(-subset_x, -subset_y),
                     pp::Rect(subset_x, subset_y, 1, 1));
   if (!FlushAndWaitForDone(&dc))
     return "Couldn't flush repaint";
   if (!IsSquareInDC(dc, background_color, pp::Rect(0, 0, 1, 1),
                     subset_color))
     return "Subset paint failed.";
 
-  return "";
+  PASS();
 }
 
 std::string TestGraphics2D::TestScroll() {
   const int w = 115, h = 117;
   pp::Graphics2D dc(pp::Size(w, h), false);
   if (dc.is_null())
     return "Failure creating a boring device.";
 
   // Make sure the device background is 0.
   if (!IsDCUniformColor(dc, 0))
@@ skipping 41 matching lines @@
 
   image_x += dx;
   image_y += dy;
 
   if (!ReadImageData(dc, &readback, pp::Point(image_x, image_y)))
     return "TC2, Couldn't read back image data.";
 
   if (!CompareImages(test_image, readback))
     return "TC2, Read back image is not the same as test image.";
 
-  return "";
+  PASS();
 }
 
 std::string TestGraphics2D::TestReplace() {
   const int w = 15, h = 17;
   pp::Graphics2D dc(pp::Size(w, h), false);
   if (dc.is_null())
     return "Failure creating a boring device";
 
   // Replacing with a different size image should fail.
   pp::ImageData weird_size(PP_IMAGEDATAFORMAT_BGRA_PREMUL,
@@ skipping 32 matching lines @@
   dc.PaintImageData(swapped, pp::Point(0, 0));
 
   // Flush and make sure the result is correct.
   if (!FlushAndWaitForDone(&dc))
     return "Couldn't flush";
 
   // The background should be green from the swapped image.
   if (!IsDCUniformColor(dc, swapped_color))
     return "Flushed color incorrect (or failure in readback).";
 
-  return "";
+  PASS();
 }
 
 std::string TestGraphics2D::TestFlush() {
   // Tests that synchronous flushes (NULL callback) fail on the main thread
   // (which is the current one).
   const int w = 15, h = 17;
   pp::Graphics2D dc(pp::Size(w, h), false);
   if (dc.is_null())
     return "Failure creating a boring device";
 
@@ skipping 21 matching lines @@
   if (rv != PP_OK && rv != PP_ERROR_WOULDBLOCK)
     return "Couldn't flush first time for multiple flush test.";
 
   if (rv != PP_OK) {
     // If the first flush would block, then a second should fail.
     rv = dc_nopaints.Flush(pp::CompletionCallback(&FlushCallbackNOP, NULL));
     if (rv == PP_OK || rv == PP_ERROR_WOULDBLOCK)
       return "Second flush succeeded before callback ran.";
   }
 
-  return "";
+  PASS();
 }