Issue 4181006: Ensure that CertStore::StoreCert never returns a cert_id of 0....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4181006: Ensure that CertStore::StoreCert never returns a cert_id of 0.... (Closed)

Created:
10 years, 1 month ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Finnur, Jay Civelli

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Ensure that CertStore::StoreCert never returns a cert_id of 0. R=finnur,jcivelli BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64622

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/cert_store.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jay Civelli

10 years, 1 month ago (2010-11-01 16:05:38 UTC) #3

LGTM

On Sat, Oct 30, 2010 at 2:53 AM,  <finnur@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/4181006/show
>