Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 418018: Remove invuca.icu table from the ICU data file again (part 2 : Windows. For p... (Closed)

Created:
11 years, 1 month ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove invuca.icu table from the ICU data file again (part 2 : Windows. For part 1, see http://codereview.chromium.org/399089/show) It was added to make Chrome not crash with a webkit patch for bug 30437 (https://bugs.webkit.org/show_bug.cgi?id=30437) However, the webkit patch was rolled back so that we don't need invuca.icu for now. Removing it will cut down the data size by 230k (before compression and in the Chrome executable on Linux/Mac and the ICU data dll on Linux). This has to be added back when it becomes necessary again to fix the aforementioned webkit bug. See also http://crbug.com/28132 (a bug about ~ 4kB of space wasted by copyright statements) TBR=evan BUG=20406 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M third_party/icu/icudt42.dll View Binary file 0 comments Download
M third_party/icu/source/data/in/icudt42l.dat View Binary file 0 comments Download

Messages

Total messages: 1 (0 generated)
jungshik at Google
11 years, 1 month ago (2009-11-20 19:51:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698