Issue 4177005: 1. Not to assert inside chroot, if so desired.

Issue 4177005: 1. Not to assert inside chroot, if so desired. (Closed)

Created:
10 years, 1 month ago by Raja Aluri

Modified:
9 years, 7 months ago

Reviewers:
adlr, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

1. Not to assert inside chroot, if so desired. 2. Source shflags, if they are in the current directory Change-Id: Id22e597a6fb71905f2d0ca5c4a1d94ce5a8a931f Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c6e23cd

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed the option name #

Total comments: 2

Patch Set 3 : fixing the 80 char limit. #

Patch Set 4 : not to assert inside chroot, if so desired. Source shflags, if they are in the current directory #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	common.sh	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cros_generate_update_payload	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sosa

http://codereview.chromium.org/4177005/diff/1/3 File cros_generate_update_payload (right): http://codereview.chromium.org/4177005/diff/1/3#newcode121 cros_generate_update_payload:121: DEFINE_boolean chroot "$FLAGS_TRUE" "Running inside chroot or outside." I'd ...

10 years, 1 month ago (2010-10-27 23:13:24 UTC) #2

sosa

Also please add BUG=<your bug id> TEST=<some indication you tested both in / out of ...

10 years, 1 month ago (2010-10-27 23:14:00 UTC) #3

sosa

10 years, 1 month ago (2010-11-02 18:39:29 UTC) #6

LGTM w/ nits

http://codereview.chromium.org/4177005/diff/7001/8002
File cros_generate_update_payload (right):

http://codereview.chromium.org/4177005/diff/7001/8002#newcode121
cros_generate_update_payload:121: DEFINE_boolean outside_chroot "$FLAGS_FALSE"
"Running outside of chroot."
alphabetical

http://codereview.chromium.org/4177005/diff/7001/8002#newcode137
cros_generate_update_payload:137: if [ -n "$FLAGS_src_image" -a 
"$FLAGS_outside_chroot" -eq "$FLAGS_FALSE" ]; then
80 chars ... might wanna just do [] && \ []

Expand Messages | Collapse Messages