Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 4176004: Reenable breakpad in the DC by enabling .chromium.org suffix. (Closed)

Created:
10 years, 1 month ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Reenable breakpad in the DC by enabling .chromium.org suffix. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64049

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M breakpad.py View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 1 month ago (2010-10-27 11:18:44 UTC) #1
jochen (gone - plz use gerrit)
10 years, 1 month ago (2010-10-27 11:21:20 UTC) #2
lgtm

http://codereview.chromium.org/4176004/diff/1/2
File breakpad.py (right):

http://codereview.chromium.org/4176004/diff/1/2#newcode79
breakpad.py:79: socket.getfqdn().endswith('.chromium.org'))):
nit indent one space less

Powered by Google App Engine
This is Rietveld 408576698