Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 4170010: [ChromeOS] Remove PanelBrowserView::Init. (Closed)

Created:
10 years, 1 month ago by xiyuan
Modified:
9 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[ChromeOS] Remove PanelBrowserView::Init. The window size handling in PanelBrowserView::Init seems no longer needed and would cause problem now. BUG=chromium-os:8258 TEST=Verify fix for chromium-os:8258. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/browser/chromeos/frame/panel_browser_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/frame/panel_browser_view.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xiyuan
The change seems working fine with ToT ChromeOS: - The 100x100 size issue in http://crosbug.com/8465 ...
10 years, 1 month ago (2010-11-01 17:16:35 UTC) #1
oshima
On 2010/11/01 17:16:35, xiyuan wrote: > The change seems working fine with ToT ChromeOS: > ...
10 years, 1 month ago (2010-11-01 20:07:11 UTC) #2
xiyuan
On 2010/11/01 20:07:11, oshima wrote: > On 2010/11/01 17:16:35, xiyuan wrote: > > The change ...
10 years, 1 month ago (2010-11-01 20:43:05 UTC) #3
oshima
On 2010/11/01 20:43:05, xiyuan wrote: > On 2010/11/01 20:07:11, oshima wrote: > > On 2010/11/01 ...
10 years, 1 month ago (2010-11-01 21:13:08 UTC) #4
xiyuan
10 years, 1 month ago (2010-11-01 23:17:27 UTC) #5
On 2010/11/01 21:13:08, oshima wrote:
> On 2010/11/01 20:43:05, xiyuan wrote:
> > On 2010/11/01 20:07:11, oshima wrote:
> > > On 2010/11/01 17:16:35, xiyuan wrote:
> > > > The change seems working fine with ToT ChromeOS:
> > > > - The 100x100 size issue in http://crosbug.com/8465 is gone;
> > > > - Unable to repro the 200x200 problem mentioned in comments. Hope it's
no
> > > longer
> > > > an issue now :p
> > > > - It works fine with Oshima's popup test page;
> > > > 
> > > > Do we want to give it a try?
> > > 
> > > sure, i'm fine if this work.
> > > how did you test 200x200? we should at least test bigger/smaller window
> > > many times.
> > 
> > I tried your test page and file browse panel for about 50+ times each. But
> never
> > see the 200x200 problem.
> 
> If you're talking about www/~oshima/test/test.html, that's not
> the test page for this. You should test panels whose initial size
> are larger and smaller than 200x200.
> 
> LGTM once you did these cases.

Tried with a popup test page for different popup sizes and so far works fine.
I'll get this in and have my finger crossed.

Powered by Google App Engine
This is Rietveld 408576698