Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: src/log.cc

Issue 4169005: Fix reporting of impossible nested calls of DOM functions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 2cc2b8ffa85fd9892a9ab0c4c7f5522bd251a911..d12aafb6df87e59c877d7ff775c8f05a57d59cf5 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -164,7 +164,10 @@ void StackTracer::Trace(TickSample* sample) {
int i = 0;
const Address callback = VMState::external_callback();
- if (callback != NULL) {
+ // Surprisingly, PC can point _exactly_ to callback start, with good
+ // probability, and this will result in reporting fake nested
+ // callback call.
+ if (callback != NULL && callback != sample->pc) {
sample->stack[i++] = callback;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698