Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: chrome/browser/chromeos/options/wifi_config_view_browsertest.cc

Issue 4169001: Rewritten parts of NetworkLibrary to work around memory corruption that prev... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/options/wifi_config_view_browsertest.cc
===================================================================
--- chrome/browser/chromeos/options/wifi_config_view_browsertest.cc (revision 64441)
+++ chrome/browser/chromeos/options/wifi_config_view_browsertest.cc (working copy)
@@ -32,16 +32,17 @@
// Test that if nothing is changed, we don't call SaveWifiNetwork.
IN_PROC_BROWSER_TEST_F(WifiConfigViewTest, NoChangeSaveTest) {
EXPECT_CALL(*mock_network_library_, SaveWifiNetwork(_)).Times(0);
- WifiConfigView* view = new WifiConfigView(NULL, WifiNetwork());
+ scoped_ptr<WifiNetwork> network(new WifiNetwork());
+ WifiConfigView* view = new WifiConfigView(NULL, network.get());
view->Save();
}
// Test that if autoconnect was changed, we call SaveWifiNetwork.
IN_PROC_BROWSER_TEST_F(WifiConfigViewTest, ChangeAutoConnectSaveTest) {
EXPECT_CALL(*mock_network_library_, SaveWifiNetwork(_)).Times(1);
- WifiNetwork remembered_network = WifiNetwork();
- remembered_network.set_favorite(true);
- WifiConfigView* view = new WifiConfigView(NULL, remembered_network);
+ scoped_ptr<WifiNetwork> remembered_network(new WifiNetwork());
+ remembered_network->set_favorite(true);
+ WifiConfigView* view = new WifiConfigView(NULL, remembered_network.get());
ASSERT_TRUE(view->autoconnect_checkbox_ != NULL);
view->autoconnect_checkbox_->SetChecked(
!view->autoconnect_checkbox_->checked());
@@ -51,9 +52,9 @@
// Test that if password was changed, we call SaveWifiNetwork.
IN_PROC_BROWSER_TEST_F(WifiConfigViewTest, ChangePasswordSaveTest) {
EXPECT_CALL(*mock_network_library_, SaveWifiNetwork(_)).Times(1);
- WifiNetwork wifi = WifiNetwork();
- wifi.set_encryption(SECURITY_WEP);
- WifiConfigView* view = new WifiConfigView(NULL, wifi);
+ scoped_ptr<WifiNetwork> wifi(new WifiNetwork());
+ wifi->set_encryption(SECURITY_WEP);
+ WifiConfigView* view = new WifiConfigView(NULL, wifi.get());
view->passphrase_textfield_->SetText(ASCIIToUTF16("test"));
view->Save();
}
« no previous file with comments | « chrome/browser/chromeos/options/wifi_config_view.cc ('k') | chrome/browser/chromeos/status/network_dropdown_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698