Issue 4167006: Mac cloud print proxy work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4167006: Mac cloud print proxy work. (Closed)

Created:
10 years, 1 month ago by Scott Byer

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, sanjeevr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac cloud print proxy work. Turn on use_cups for the Mac, add in the required library, and tweak the code to get it linking. There is still more work to do; this is just a gyp-oriented change to get things started. BUG=none TEST=All targets still build on all platforms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64441

Patch Set 1 #

Patch Set 2 : Clean up condition #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -14 lines)			Patch
M	build/common.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View		2 chunks	+16 lines, -6 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_cups.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download
M	printing/backend/print_backend_cups.cc	View		4 chunks	+6 lines, -0 lines	1 comment	Download
M	printing/printing.gyp	View		2 chunks	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

10 years, 1 month ago (2010-10-29 18:46:42 UTC) #3

LGTM++

http://codereview.chromium.org/4167006/diff/5001/6003
File chrome/service/cloud_print/print_system_cups.cc (right):

http://codereview.chromium.org/4167006/diff/5001/6003#newcode9
chrome/service/cloud_print/print_system_cups.cc:9: #include <errno.h>
You can also remove dlfcn.h and errno.h.

http://codereview.chromium.org/4167006/diff/5001/6004
File printing/backend/print_backend_cups.cc (right):

http://codereview.chromium.org/4167006/diff/5001/6004#newcode9
printing/backend/print_backend_cups.cc:9: #if !defined(OS_MACOSX)
You can also wrap dlfcn.h and errno.h inside the #if.

Expand Messages | Collapse Messages