Issue 4165013: Re-landing issue 4202006 (http://codereview.chromium.org/4202006/show) which ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4165013: Re-landing issue 4202006 (http://codereview.chromium.org/4202006/show) which ... (Closed)

Created:
10 years, 1 month ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
Scott Byer

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Re-landing issue 4202006 (http://codereview.chromium.org/4202006/show) which was reverted because of a Valgrind leak. Fixed the memory leak in the unit-test. BUG=None. TEST=Unit-tests, Valgrind bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64496

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1047 lines, -573 lines)			Patch
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_consts.h	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_consts.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_helpers.h	View	1 chunk	+1 line, -22 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_helpers.cc	View	3 chunks	+4 lines, -38 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.cc	View	17 chunks	+152 lines, -148 lines	0 comments	Download
A	chrome/service/cloud_print/cloud_print_url_fetcher.h	View	1 chunk	+118 lines, -0 lines	0 comments	Download
A	chrome/service/cloud_print/cloud_print_url_fetcher.cc	View	1 chunk	+146 lines, -0 lines	0 comments	Download
A	chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc	View	1 chunk	+353 lines, -0 lines	0 comments	Download
M	chrome/service/cloud_print/job_status_updater.h	View	3 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/service/cloud_print/job_status_updater.cc	View	1 chunk	+19 lines, -28 lines	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.h	View	7 chunks	+76 lines, -71 lines	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.cc	View	9 chunks	+152 lines, -250 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2010/10/29 18:35:13, sanjeevr wrote:
>

Expand Messages | Collapse Messages