Issue 4165009: Add components to pass vm flag to dev server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4165009: Add components to pass vm flag to dev server. (Closed)

Created:
10 years, 1 month ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Add components to pass vm flag to dev server. BUG=8306 TEST=Ran au_test_harness with CL for adding vm option for the devserver on the last channel release and my TOT. All tests passed. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=113739c

Patch Set 1 #

Patch Set 2 : Remove changes #

Patch Set 3 : Trim more fat #

Patch Set 4 : Re add source image #

Total comments: 1

Patch Set 5 : Nit #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
M	bin/cros_au_test_harness.py	View	1 2 3	6 chunks	+10 lines, -9 lines	0 comments	Download
M	bin/cros_run_vm_update	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	image_to_live.sh	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 1 month ago (2010-10-29 06:08:53 UTC) #2

LGTM w/ a nit.

http://codereview.chromium.org/4165009/diff/6001/7003
File image_to_live.sh (right):

http://codereview.chromium.org/4165009/diff/6001/7003#newcode42
image_to_live.sh:42: DEFINE_boolean for_vm ${FLAGS_FALSE} "Image is for a vm."
keep the flags declaration sorted?

Expand Messages | Collapse Messages