Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 4165006: userfeedback: remove wpa_supplicant log (Closed)

Created:
10 years, 1 month ago by Sam Leffler
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

userfeedback: remove wpa_supplicant log The /var/log/hostap.log file hasn't been used since we turned off wpa_supplicant logging. This used to not be an issue but recent mods to userfeedback cause a tab to be recreated with <no value>. Fix this by removing the entry from the .lst file. BUG=none TEST=gmerge to device; run chrome:system and verify the wpa_supplicant tab is gone Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=54372e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M etc/sys_log_utils.lst View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Leffler
10 years, 1 month ago (2010-10-28 16:36:59 UTC) #1
Chris Masone
10 years, 1 month ago (2010-10-28 16:39:17 UTC) #2
LGTM

On Thu, Oct 28, 2010 at 9:36 AM, <sleffler@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> userfeedback: remove wpa_supplicant log
>
> The /var/log/hostap.log file hasn't been used since we turned off
> wpa_supplicant logging.  This used to not be an issue but recent
> mods to userfeedback cause a tab to be recreated with <no value>.
> Fix this by removing the entry from the .lst file.
>
> BUG=none
> TEST=gmerge to device; run chrome:system and verify the wpa_supplicant tab
> is
> gone
>
> Please review this at http://codereview.chromium.org/4165006/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/userfeedback.git
>
> Affected files:
>  M etc/sys_log_utils.lst
>
>
> Index: etc/sys_log_utils.lst
> diff --git a/etc/sys_log_utils.lst b/etc/sys_log_utils.lst
> index
>
cc71353508122357978d3bc1eee1e75e625587f7..2011badf941e45b91848cef1573129c77099ca60
> 100755
> --- a/etc/sys_log_utils.lst
> +++ b/etc/sys_log_utils.lst
> @@ -41,4 +41,3 @@ touchpad,/opt/google/touchpad/tpcontrol status
>  ui_log,/usr/share/userfeedback/scripts/get_log /var/log/ui/ui.LATEST
>  uname,/bin/uname -a
>  update_engine.log,/usr/share/userfeedback/scripts/get_log
> /var/log/update_engine.log
> -wpa_supplicant,/usr/share/userfeedback/scripts/getmsgs --last '30 minutes'
> /var/log/hostap.log
>
>
>

Powered by Google App Engine
This is Rietveld 408576698