Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3051)

Unified Diff: base/vlog_unittest.cc

Issue 4164011: Integrate ETW with VLOG logging. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/vlog.cc ('k') | ceee/testing/utils/test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/vlog_unittest.cc
===================================================================
--- base/vlog_unittest.cc (revision 65044)
+++ base/vlog_unittest.cc (working copy)
@@ -18,12 +18,13 @@
};
TEST_F(VlogTest, NoVmodule) {
- EXPECT_EQ(0, VlogInfo("", "").GetVlogLevel("test1"));
- EXPECT_EQ(0, VlogInfo("0", "").GetVlogLevel("test2"));
- EXPECT_EQ(0, VlogInfo("blah", "").GetVlogLevel("test3"));
- EXPECT_EQ(0, VlogInfo("0blah1", "").GetVlogLevel("test4"));
- EXPECT_EQ(1, VlogInfo("1", "").GetVlogLevel("test5"));
- EXPECT_EQ(5, VlogInfo("5", "").GetVlogLevel("test6"));
+ int min_log_level = 0;
+ EXPECT_EQ(0, VlogInfo("", "", &min_log_level).GetVlogLevel("test1"));
+ EXPECT_EQ(0, VlogInfo("0", "", &min_log_level).GetVlogLevel("test2"));
+ EXPECT_EQ(0, VlogInfo("blah", "", &min_log_level).GetVlogLevel("test3"));
+ EXPECT_EQ(0, VlogInfo("0blah1", "", &min_log_level).GetVlogLevel("test4"));
+ EXPECT_EQ(1, VlogInfo("1", "", &min_log_level).GetVlogLevel("test5"));
+ EXPECT_EQ(5, VlogInfo("5", "", &min_log_level).GetVlogLevel("test6"));
}
TEST_F(VlogTest, MatchVlogPattern) {
@@ -78,7 +79,8 @@
const char kVSwitch[] = "-1";
const char kVModuleSwitch[] =
"foo=,bar=0,baz=blah,,qux=0blah1,quux=1,corge.ext=5";
- VlogInfo vlog_info(kVSwitch, kVModuleSwitch);
+ int min_log_level = 0;
+ VlogInfo vlog_info(kVSwitch, kVModuleSwitch, &min_log_level);
EXPECT_EQ(-1, vlog_info.GetVlogLevel("/path/to/grault.cc"));
EXPECT_EQ(0, vlog_info.GetVlogLevel("/path/to/foo.cc"));
EXPECT_EQ(0, vlog_info.GetVlogLevel("D:\\Path\\To\\bar-inl.mm"));
@@ -92,7 +94,8 @@
TEST_F(VlogTest, VmoduleDirs) {
const char kVModuleSwitch[] =
"foo/bar.cc=1,baz\\*\\qux.cc=2,*quux/*=3,*/*-inl.h=4";
- VlogInfo vlog_info("", kVModuleSwitch);
+ int min_log_level = 0;
+ VlogInfo vlog_info("", kVModuleSwitch, &min_log_level);
EXPECT_EQ(0, vlog_info.GetVlogLevel("/foo/bar.cc"));
EXPECT_EQ(0, vlog_info.GetVlogLevel("bar.cc"));
EXPECT_EQ(1, vlog_info.GetVlogLevel("foo/bar.cc"));
« no previous file with comments | « base/vlog.cc ('k') | ceee/testing/utils/test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698