Generate example JSON policy configuration files

Generate example JSON policy configuration files

Also fix filtering of single (non-groupped) policies by platforms.

BUG=56531
TEST=JsonWriterUnittest.*,PolicyTemplateGeneratorUnittest.testPolicyFiltering

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64748

[gfeher, 2010-10-27 13:46:59]

Please review my CL.

[Jói, 2010-10-27 15:13:10]

LGTM

[markusheintz_, 2010-10-27 15:35:10]

Do all unit-tests pass? :-)

Here are some initial comments.

http://codereview.chromium.org/4164006/diff/13001/14002
File
tools/grit/grit/format/policy_templates/policy_template_generator_unittest.py
(right):

http://codereview.chromium.org/4164006/diff/13001/14002#newcode291
tools/grit/grit/format/policy_templates/policy_template_generator_unittest.py:291:
self.tester.assertEquals(policy['name'][0:6],
I'm not sure if it is a good idea to have the asserts inside the Mock?

I guess it's be much more readable and more obvious what is asserted if any
asserts are in the test or in special assert methods.

This would also all to reuse the MockWriter more easily and reduce dependencies.

http://codereview.chromium.org/4164006/diff/13001/14002#newcode304
tools/grit/grit/format/policy_templates/policy_template_generator_unittest.py:304:
LocalMockWriter(
continuing my previous comment:

It is not clear to my what this test tests or what get asserted. What is
expected and what is the actual result?

It'd be better if you fetch the result from the MochWriter and compare it with
an expected result. Then it would be obvious what this test does.

http://codereview.chromium.org/4164006/diff/13001/14007
File tools/grit/grit/tool/build.py (right):

http://codereview.chromium.org/4164006/diff/13001/14007#newcode185
tools/grit/grit/tool/build.py:185: 'doc', 'json'):
Why is the list of output types here different to the one in
tools/grit/grit/node/misc.py ?

[gfeher, 2010-10-27 16:14:05]

> Do all unit-tests pass? :-)
This time they do. :)

http://codereview.chromium.org/4164006/diff/13001/14002
File
tools/grit/grit/format/policy_templates/policy_template_generator_unittest.py
(right):

http://codereview.chromium.org/4164006/diff/13001/14002#newcode291
tools/grit/grit/format/policy_templates/policy_template_generator_unittest.py:291:
self.tester.assertEquals(policy['name'][0:6],
On 2010/10/27 15:35:10, markusheintz_ wrote:
> I'm not sure if it is a good idea to have the asserts inside the Mock?
> 
> I guess it's be much more readable and more obvious what is asserted if any
> asserts are in the test or in special assert methods.
> 
> This would also all to reuse the MockWriter more easily and reduce
dependencies.

This only tests if policies are written after their group is started. I just
realized that this is also testes in testPolicies, so I am removing it from here
if you don't object.

http://codereview.chromium.org/4164006/diff/13001/14002#newcode304
tools/grit/grit/format/policy_templates/policy_template_generator_unittest.py:304:
LocalMockWriter(
On 2010/10/27 15:35:10, markusheintz_ wrote:
> continuing my previous comment:
> 
> It is not clear to my what this test tests or what get asserted. What is
> expected and what is the actual result?
> 
> It'd be better if you fetch the result from the MochWriter and compare it with
> an expected result. Then it would be obvious what this test does.

Done.

http://codereview.chromium.org/4164006/diff/13001/14007
File tools/grit/grit/tool/build.py (right):

http://codereview.chromium.org/4164006/diff/13001/14007#newcode185
tools/grit/grit/tool/build.py:185: 'doc', 'json'):
On 2010/10/27 15:35:10, markusheintz_ wrote:
> Why is the list of output types here different to the one in
> tools/grit/grit/node/misc.py ?

Because this controls the encoding of the output files, while misc.py invokes
the writers.

Adm,admx and adml is utf_16, that's why they are not here. (BTW adm specificly
needs to be in utf16. I am not sure about adml and admx, but they definitely
work in utf16.)

[markusheintz_, 2010-10-27 17:11:21]

http://codereview.chromium.org/4164006/diff/13001/14004
File tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py
(right):

http://codereview.chromium.org/4164006/diff/13001/14004#newcode72
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:72:
expected_output = '''{
pls see comment below.

http://codereview.chromium.org/4164006/diff/13001/14004#newcode101
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:101:
}'''
same here

http://codereview.chromium.org/4164006/diff/13001/14004#newcode135
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:135:
}'''
same here

http://codereview.chromium.org/4164006/diff/13001/14004#newcode163
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:163:
}'''
I was told that it would be style guide conforming to write this as a sequence
of strings:

('{'
 '  "ListPolicy": ["foo", "bar"]'
 '}')

http://codereview.chromium.org/4164006/diff/13001/14004#newcode232
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:232:
}'''
pls see comment above

[gfeher, 2010-10-27 17:20:11]

http://codereview.chromium.org/4164006/diff/13001/14004
File tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py
(right):

http://codereview.chromium.org/4164006/diff/13001/14004#newcode72
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:72:
expected_output = '''{
On 2010/10/27 17:11:21, markusheintz_ wrote:
> pls see comment below.

Done.

http://codereview.chromium.org/4164006/diff/13001/14004#newcode101
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:101:
}'''
On 2010/10/27 17:11:21, markusheintz_ wrote:
> same here

Done.

http://codereview.chromium.org/4164006/diff/13001/14004#newcode135
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:135:
}'''
On 2010/10/27 17:11:21, markusheintz_ wrote:
> same here

Done.

http://codereview.chromium.org/4164006/diff/13001/14004#newcode163
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:163:
}'''
On 2010/10/27 17:11:21, markusheintz_ wrote:
> I was told that it would be style guide conforming to write this as a sequence
> of strings:
> 
> ('{'
>  '  "ListPolicy": ["foo", "bar"]'
>  '}')

Done.

http://codereview.chromium.org/4164006/diff/13001/14004#newcode232
tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py:232:
}'''
On 2010/10/27 17:11:21, markusheintz_ wrote:
> pls see comment above

Done.

[gfeher, 2010-11-02 08:41:19]

Made more multiline strings nicer.

[markusheintz_, 2010-11-02 15:17:32]

LGTM with nit if you like: %s/\\'/"/g