Prevented access to WEP passphrase from UI. Fixed forget network button in se...

Prevented access to WEP passphrase from UI. Fixed forget network button in settings.

TEST=make sure we don't show WEP passphrase in UI, make sure forget network button works again
BUG=chromium-os:8413, chomium-os:8441
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64976

[xiyuan, 2010-11-01 18:36:52]

http://codereview.chromium.org/4162004/diff/1/5
File chrome/browser/resources/options/chromeos_internet_detail.html (right):

http://codereview.chromium.org/4162004/diff/1/5#newcode64
chrome/browser/resources/options/chromeos_internet_detail.html:64: <td
class="option-name" i18n-content="inetPassProtected"></td>
Why we remove <input id="inetPass">? We don't want user to input password in UI
at all?

[zel, 2010-11-01 19:06:11]

http://codereview.chromium.org/4162004/diff/1/5
File chrome/browser/resources/options/chromeos_internet_detail.html (right):

http://codereview.chromium.org/4162004/diff/1/5#newcode64
chrome/browser/resources/options/chromeos_internet_detail.html:64: <td
class="option-name" i18n-content="inetPassProtected"></td>
On 2010/11/01 18:36:52, xiyuan wrote:
> Why we remove <input id="inetPass">? We don't want user to input password in
UI
> at all?

This is not where we ask for WEP passphrase anymore. UI for that is inlined with
the network connection list.

[xiyuan, 2010-11-01 19:12:37]

http://codereview.chromium.org/4162004/diff/1/5
File chrome/browser/resources/options/chromeos_internet_detail.html (right):

http://codereview.chromium.org/4162004/diff/1/5#newcode64
chrome/browser/resources/options/chromeos_internet_detail.html:64: <td
class="option-name" i18n-content="inetPassProtected"></td>
On 2010/11/01 19:06:11, zel wrote:
> On 2010/11/01 18:36:52, xiyuan wrote:
> > Why we remove <input id="inetPass">? We don't want user to input password in
> UI
> > at all?
> 
> This is not where we ask for WEP passphrase anymore. UI for that is inlined
with
> the network connection list.
Per discussion, let's remove all $('inetPass') in chromeos_internet_options.js
then.

[zel, 2010-11-01 19:40:44]

On 2010/11/01 19:12:37, xiyuan wrote:
> http://codereview.chromium.org/4162004/diff/1/5
> File chrome/browser/resources/options/chromeos_internet_detail.html (right):
> 
> http://codereview.chromium.org/4162004/diff/1/5#newcode64
> chrome/browser/resources/options/chromeos_internet_detail.html:64: <td
> class="option-name" i18n-content="inetPassProtected"></td>
> On 2010/11/01 19:06:11, zel wrote:
> > On 2010/11/01 18:36:52, xiyuan wrote:
> > > Why we remove <input id="inetPass">? We don't want user to input password
in
> > UI
> > > at all?
> > 
> > This is not where we ask for WEP passphrase anymore. UI for that is inlined
> with
> > the network connection list.
> Per discussion, let's remove all $('inetPass') in chromeos_internet_options.js
> then.



I have removed $('inetPass') and dead code related to that path.

[xiyuan, 2010-11-01 20:41:44]

LGTM

There is a $('inetPass') in InternetOptions.setDetails. We might want to remove
that as well.

[zel, 2010-11-01 21:51:30]

http://codereview.chromium.org/4162004/diff/9001/10006
File chrome/browser/resources/options/chromeos_internet_options.js (left):

http://codereview.chromium.org/4162004/diff/9001/10006#oldcode125
chrome/browser/resources/options/chromeos_internet_options.js:125:
newinfo.push($('inetPass').value);
nope, I don't have this anymore here

[kochi, 2010-11-02 07:12:13]

LGTM, drive-by review.

http://codereview.chromium.org/4162004/diff/9001/10002
File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):

http://codereview.chromium.org/4162004/diff/9001/10002#newcode650
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:650: //
dictionary.SetString("pass", network->passphrase());
Why not removing this line?

Actually, showPasswordEntry() only looks at
dictionary.servicePath.

You can remove line 644-651 entirely.

[zel, 2010-11-03 20:16:19]

http://codereview.chromium.org/4162004/diff/9001/10002
File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):

http://codereview.chromium.org/4162004/diff/9001/10002#newcode650
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:650: //
dictionary.SetString("pass", network->passphrase());
On 2010/11/02 07:12:14, tkochi wrote:
> Why not removing this line?
> 
> Actually, showPasswordEntry() only looks at
> dictionary.servicePath.
> 
> You can remove line 644-651 entirely.

Done. Actually, I can't remove everything here since cert networks still need
this info for displaying purposes.

[kochi, 2010-11-04 08:07:12]

On Thu, Nov 4, 2010 at 5:16 AM,  <zelidrag@chromium.org> wrote:
>
> http://codereview.chromium.org/4162004/diff/9001/10002
> File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):
>
> http://codereview.chromium.org/4162004/diff/9001/10002#newcode650
> chrome/browser/chromeos/dom_ui/internet_options_handler.cc:650: //
> dictionary.SetString("pass", network->passphrase());
> On 2010/11/02 07:12:14, tkochi wrote:
>>
>> Why not removing this line?
>
>> Actually, showPasswordEntry() only looks at
>> dictionary.servicePath.
>
>> You can remove line 644-651 entirely.
>
> Done. Actually, I can't remove everything here since cert networks still
> need this info for displaying purposes.

I don't think so.  This function is only called for encrypted Wifi and
not for cert networks.

FYI, I created a cleanup fix for this.
http://codereview.chromium.org/4405002/show

-- 
Takayoshi Kochi