vbutil_kernel: support exporting a keyblock file during verify

vbutil_kernel: support exporting a keyblock file during verify

Reuses the --keyblock argument to output a keyblock if used
during Verify().

TEST=built, ran on a kernel; check if it worked for cgpt find -M :)
BUG=chromium-os:7451
Change-Id: Ibf1365dbdaeaf87442e0d12d048bc070f35662ad

[gauravsh, 2010-10-26 02:06:54]

Bonum mihi videtur (with nits)

You might also want to run "make runtests" as an additional sanity test (though
I believe there aren't any tests for vbutil_kernel yet :|)

http://codereview.chromium.org/4160001/diff/1/2
File utility/vbutil_kernel.c (right):

http://codereview.chromium.org/4160001/diff/1/2#newcode677
utility/vbutil_kernel.c:677: FILE *f = NULL;
FILE* f (to be consistent with the rest of the file)

http://codereview.chromium.org/4160001/diff/1/2#newcode684
utility/vbutil_kernel.c:684: error("Can't open key block file %s\n",
key_block_file);
s/open/write/

[gauravsh, 2010-10-26 02:11:01]

Also, you should also update the help string. :)

On 2010/10/26 02:06:54, gauravsh wrote:
> Bonum mihi videtur (with nits)
> 
> You might also want to run "make runtests" as an additional sanity test
(though
> I believe there aren't any tests for vbutil_kernel yet :|)
> 
> http://codereview.chromium.org/4160001/diff/1/2
> File utility/vbutil_kernel.c (right):
> 
> http://codereview.chromium.org/4160001/diff/1/2#newcode677
> utility/vbutil_kernel.c:677: FILE *f = NULL;
> FILE* f (to be consistent with the rest of the file)
> 
> http://codereview.chromium.org/4160001/diff/1/2#newcode684
> utility/vbutil_kernel.c:684: error("Can't open key block file %s\n",
> key_block_file);
> s/open/write/

[Will Drewry, 2010-10-26 02:11:55]

Done.

Does BMV register as LGTM? ;)

[gauravsh, 2010-10-26 02:13:45]

On Mon, Oct 25, 2010 at 7:11 PM,  <wad@chromium.org> wrote:
> Done.
>
> Does BMV register as LGTM? ;)

It should. We are firm believers in i18n, no? :)


>
> http://codereview.chromium.org/4160001/show
>



-- 
-g

[Will Drewry, 2010-10-26 02:21:04]

Cool - help string updated as well!

[gauravsh, 2010-10-26 02:22:41]

LGTM

On Mon, Oct 25, 2010 at 7:13 PM, Gaurav Shah <gauravsh@chromium.org> wrote:
> On Mon, Oct 25, 2010 at 7:11 PM,  <wad@chromium.org> wrote:
>> Done.
>>
>> Does BMV register as LGTM? ;)
>
> It should. We are firm believers in i18n, no? :)
>
>
>>
>> http://codereview.chromium.org/4160001/show
>>
>
>
>
> --
> -g
>



-- 
-g

[Bill Richardson, 2010-10-26 02:30:35]

LGTM.

Note that you can already verify and extract just the keyblock using
vbutil_keyblock --unpack KERNEL

That's a happy side effect of the fact that the keyblock is the first thing in
the kernel blob.

[Will Drewry, 2010-10-26 02:37:58]

On Mon, Oct 25, 2010 at 9:30 PM,  <wfrichar@chromium.org> wrote:
> LGTM.
>
> Note that you can already verify and extract just the keyblock using
> vbutil_keyblock --unpack KERNEL

I keep getting:

vbutil_keyblock: keyblock requires public key to verify

But I haven't checked it out :)

>
> That's a happy side effect of the fact that the keyblock is the first thing
> in
> the kernel blob.
>
>
>
> http://codereview.chromium.org/4160001/show
>