Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4154002: New statusbar images for ChromeOS (Closed)

Created:
10 years, 2 months ago by Charlie Lee
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, Paweł Hajdan Jr., davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

New statusbar images for ChromeOS. Cleaned up hacks for positioning statusbar icons. Changed network connecting animation to fading in and out of network bars. BUG=chromium-os:8135 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63984

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -199 lines) Patch
M chrome/app/theme/statusbar_battery10c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery10d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery11c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery11d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery12c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery12d.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_battery13c.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_battery13d.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_battery14c.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_battery14d.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_battery15c.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_battery15d.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_battery16c.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_battery16d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery1c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery1d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery2c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery2d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery3c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery3d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery4c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery4d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery5c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery5d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery6c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery6d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery7c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery7d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery8c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery8d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery9c.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery9d.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery_charged.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery_missing.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery_pressed.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_battery_unknown.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_bug.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_feedback.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_feedback_pressed.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_3g.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_3g_error.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_3g_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_3g_vlowdata.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_3g_warn.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars0.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars0b.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars1.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars1_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars1_vlowdata.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars1b.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars1o.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars1r.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars2.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars2_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars2_vlowdata.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars2b.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars2o.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars2r.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars3.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars3_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars3_vlowdata.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars3b.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars3o.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars3r.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars4.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars4_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars4_vlowdata.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars4b.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars4o.png View Binary file 0 comments Download
A chrome/app/theme/statusbar_network_bars4r.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars5.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars5_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars5_vlowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars5b.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars6.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars6_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars6_vlowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars6b.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars7.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars7_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars7_vlowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars7b.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars8.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars8_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars8_vlowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars8b.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars9.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars9_lowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars9_vlowdata.png View Binary file 0 comments Download
D chrome/app/theme/statusbar_network_bars9b.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_bars_pressed.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_disconnected.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_edge.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_secure.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_warning.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_network_wired_pressed.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_wired.png View Binary file 0 comments Download
M chrome/app/theme/statusbar_wiredb.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 3 chunks +20 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/internet_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/internet_page_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/feedback_menu_button.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/status/feedback_menu_button.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 1 2 5 chunks +12 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_button.h View 1 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_button.cc View 1 2 3 7 chunks +38 lines, -46 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button.h View 2 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button.cc View 1 4 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button_browsertest.cc View 6 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.h View 2 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.cc View 2 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_view.cc View 2 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Charlie Lee
10 years, 2 months ago (2010-10-26 01:34:37 UTC) #1
DaveMoore
10 years, 1 month ago (2010-10-26 21:34:23 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698