archive_build.sh - Issue 4153001: Fix two very broken tests for null strings in archive_build.sh - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(17)

My Issues | Starred Open | Closed | All

Unified Diff: archive_build.sh

Issue 4153001: Fix two very broken tests for null strings in archive_build.sh (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git

Patch Set: Update for review comments Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: archive_build.sh

diff --git a/archive_build.sh b/archive_build.sh

index 64a4ee4093a0f6c65b13f91726784e036a5f87e3..785273e14b0dc103933d923b53704a10abde4297 100755

--- a/archive_build.sh

+++ b/archive_build.sh

@@ -67,7 +67,7 @@ fi

# Die on any errors.

set -e

-if [ -z $DEFAULT_USED ]

+if [ -z "$DEFAULT_USED" ]

then

if [ $FLAGS_test_mod -eq $FLAGS_TRUE ] || \

[ $FLAGS_factory_install_mod -eq $FLAGS_TRUE ] || \

@@ -244,7 +244,7 @@ function gsutil_archive() {

echo "Using gsutil to archive to ${OUT_PATH}..."

${FLAGS_gsutil} cp ${IN_PATH} ${FULL_OUT_PATH}

${FLAGS_gsutil} setacl ${FLAGS_acl} ${FULL_OUT_PATH}

- if [ $FLAGS_gsd_gen_index != "" ]

+ if [ -n "$FLAGS_gsd_gen_index" ]

then

echo "Updating indexes..."

${FLAGS_gsd_gen_index} \

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698