Issue 415001: Merge 32335...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 415001: Merge 32335... (Closed)

Created:
11 years, 1 month ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 32335 Fixes several focus issue with popup in the extensions' browser actions: when opening a browser action popup, it gets the focus. tab traversal now works in the popup pressing esc closes the popup (if the keyboard event is not processed by the page) BUG=22654, 28087, 28086 TEST=Create an extension with a browser extension that shows a popup. Make the popup so that it has a textfield (that gets focused when the popup show) and a button. Install the extension. Open the popup, the textfield should have focus. Press tab, the focus should go to the button. Press Esc, the popup should be closed. Review URL: http://codereview.chromium.org/402036 TBR=jcampan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32529

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -2 lines)			Patch
M	chrome/browser/extensions/extension_host.cc	View	3 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/browser_bubble_win.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_view.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages