Issue 4149006: Mark some functions that wait on other processes as unsafe for IO/UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4149006: Mark some functions that wait on other processes as unsafe for IO/UI. (Closed)

Created:
10 years, 1 month ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mark some functions that wait on other processes as unsafe for IO/UI. This might have helped catch an earlier bug, where we were shelling out to lsb_release on Linux. BUG=21782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68258

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	base/process_util_posix.cc	View		3 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Evan Martin

I think this wouldn't have actually caught that bug, because we did the lsb_release call ...

10 years, 1 month ago (2010-10-28 18:34:11 UTC) #1

LGTM