Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2494)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.h

Issue 4148004: Mac gpu: on gpu<->nongpu transitions, make sure to not show uninitialized memory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments 2 Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host_view_mac.h
diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.h b/chrome/browser/renderer_host/render_widget_host_view_mac.h
index b448a8a91d391b87cbc0dedbfd944eaaca55ed58..44807b2c3dce4a26e9291156fd6423d7d1a44eba 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_mac.h
+++ b/chrome/browser/renderer_host/render_widget_host_view_mac.h
@@ -266,6 +266,14 @@ class RenderWidgetHostViewMac : public RenderWidgetHostView {
const std::string& selected_text() const { return selected_text_; }
+ void UpdateRootGpuViewVisibility(bool show_gpu_widget);
+
+ // When rendering transitions from gpu to software, the gpu widget can't be
+ // hidden until the software backing store has been updated. This method
+ // checks if the GPU view needs to be hidden and hides it if necessary. It
+ // should be called after the software backing store has been painted to.
+ void HandleDelayedGpuViewHiding();
+
// These member variables should be private, but the associated ObjC class
// needs access to them and can't be made a friend.
@@ -341,6 +349,11 @@ class RenderWidgetHostViewMac : public RenderWidgetHostView {
// selected text on the renderer.
std::string selected_text_;
+ // When rendering transitions from gpu to software, the gpu widget can't be
+ // hidden until the software backing store has been updated. This variable is
+ // set when the gpu widget needs to be hidden once a paint is completed.
+ bool needs_gpu_visibility_update_after_repaint_;
+
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewMac);
};

Powered by Google App Engine
This is Rietveld 408576698