Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 4147008: Automate bitmap image regeneration. (Closed)

Created:
10 years, 1 month ago by vb
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Nick Sanders
Base URL:
gitrw.chromium.org:/vboot_reference.git
Visibility:
Public.

Description

Automate bitmap image regeneration. This CL modifies the bitmap generation script as follows: - allow to specify required geometry of the images and to generate a single set per FWID instead of generating all geometries for all FWIDs - store the images and the zip archive in a directory with the name derived from FWID. The CL also adds a wrapper, which given the path to the tree containing already released GBB firmware volumes would find all valid (as verified by the CRC in the file name) FWIDs and generate new images for all detected FWIDs. The geometry of the generated images is based on the FWID contents, Marios get 1280x800 and ZGAs - 1366x768. Once this script stops running, the scripts/bitmaps directory contains a set of subdirectories, one per generated set of images. Another script ran by cygwin on a windows machine was used to pick up all image sets and regenerate GBB firmware volumes, will be published under a separate CL. BUG=chrome-os-partner:792 TEST=see below: Ran the following command: ./process_all_targets.sh ../../../chromeos-internal/third_party/autotest/files/client/site_tests/ After command completed, the following out_* directories showed up: (bitmaps 144) ls -1d out* out_ACER_ASPIREONE_001_8012/ out_ACER_ASPIREONE_001_DEV_0393/ out_ACER_ASPIREONE_002_0710/ out_ACER_ASPIREONE_002_DEV_1017/ out_IEC_MARIO_FISH_2330/ out_IEC_MARIO_PONY_6101/ out_IEC_MARIO_PONY_DEV_3342/ out_IEC_MARIO_PONY_DVT_8784/ out_IEC_MARIO_PONY_EVT_3495/ out_IEC_MARIO_PONY_PREDVT_6766/ with typical directory contents as follows: (bitmaps 145) tree out_ACER_ASPIREONE_001_8012/ out_ACER_ASPIREONE_001_8012/ |-- 1366x768.zip |-- BlankBmp | `-- BlankBmp.bmp |-- DeveloperBmp | `-- DeveloperBmp.bmp |-- RecoveryBmp | `-- RecoveryBmp.bmp |-- RecoveryMissingOSBmp | `-- RecoveryMissingOSBmp.bmp `-- RecoveryNoOSBmp `-- RecoveryNoOSBmp.bmp 5 directories, 6 files Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=10fce4a

Patch Set 1 : Automate bitmap image regeneration. #

Total comments: 2

Patch Set 2 : Modified to address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -33 lines) Patch
M scripts/bitmaps/make_bmp_images.sh View 6 chunks +18 lines, -33 lines 0 comments Download
A scripts/bitmaps/process_all_targets.sh View 1 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vb
Bill, what's the bug number for this issue - I did not see anything appropriate ...
10 years, 1 month ago (2010-10-28 00:44:30 UTC) #1
Bill Richardson
LGTM. This is much nicer. Thanks, Vadim! http://codereview.chromium.org/4147008/diff/2001/3002 File scripts/bitmaps/process_all_targets.sh (right): http://codereview.chromium.org/4147008/diff/2001/3002#newcode29 scripts/bitmaps/process_all_targets.sh:29: # string's ...
10 years, 1 month ago (2010-10-28 15:28:53 UTC) #2
Bill Richardson
Oh, and the bug is http://code.google.com/p/chrome-os-partner/issues/detail?id=792
10 years, 1 month ago (2010-10-28 17:09:29 UTC) #3
Randall Spangler
LGTM
10 years, 1 month ago (2010-10-28 17:20:09 UTC) #4
vb
10 years, 1 month ago (2010-10-29 15:08:03 UTC) #5
http://codereview.chromium.org/4147008/diff/2001/3002
File scripts/bitmaps/process_all_targets.sh (right):

http://codereview.chromium.org/4147008/diff/2001/3002#newcode29
scripts/bitmaps/process_all_targets.sh:29: # string's CRC32 and print the last
for hex digits of the crc.
On 2010/10/28 15:28:54, Bill Richardson wrote:
> s/for/four/

Done.

Powered by Google App Engine
This is Rietveld 408576698