Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 4147002: Add delta update support to imaging tools. (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add delta update support to imaging tools. Change-Id: I3ad6d418a1d47f47b78ba4e011c83bc569041475 BUG=6912 TEST=Ran with http://codereview.chromium.org/4129005/show with and without src_image Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8e3e834

Patch Set 1 #

Patch Set 2 : Add differential update support to image_to_live. #

Patch Set 3 : Fix typo #

Total comments: 1

Patch Set 4 : indent #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M bin/cros_run_vm_update View 2 chunks +3 lines, -0 lines 0 comments Download
M image_to_live.sh View 1 2 3 4 chunks +20 lines, -11 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
sosa
10 years, 1 month ago (2010-10-26 22:45:38 UTC) #1
sosa
Ping On Tue, Oct 26, 2010 at 3:45 PM, <sosa@chromium.org> wrote: > Reviewers: kmixter1, dgarrett, ...
10 years, 1 month ago (2010-10-27 03:29:14 UTC) #2
sosa
+davidjames
10 years, 1 month ago (2010-10-27 04:21:15 UTC) #3
petkov
LGTM http://codereview.chromium.org/4147002/diff/7001/8002 File image_to_live.sh (right): http://codereview.chromium.org/4147002/diff/7001/8002#newcode133 image_to_live.sh:133: --src_image=\"$(reinterpret_path_for_chroot ${FLAGS_src_image})\"" indent?
10 years, 1 month ago (2010-10-27 04:36:58 UTC) #4
sosa
Thanks for the review! On Tue, Oct 26, 2010 at 9:37 PM, <petkov@chromium.org> wrote: > ...
10 years, 1 month ago (2010-10-27 04:37:38 UTC) #5
kmixter1
10 years, 1 month ago (2010-10-27 17:15:51 UTC) #6
LGTM

http://codereview.chromium.org/4147002/diff/3003/13002
File image_to_live.sh (right):

http://codereview.chromium.org/4147002/diff/3003/13002#newcode99
image_to_live.sh:99: local relative_path=$(echo ${path_abs_path} \
I think you can do this with less work:

${path_abs_path#${gclient_root_abs_path}*}

Powered by Google App Engine
This is Rietveld 408576698