chrome/browser/printing/print_dialog_cloud_unittest.cc - Issue 4146015: Minimum UI change for Cloud Print dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_dialog_cloud_unittest.cc

Issue 4146015: Minimum UI change for Cloud Print dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit test. Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_dialog_cloud_unittest.cc

diff --git a/chrome/browser/printing/print_dialog_cloud_unittest.cc b/chrome/browser/printing/print_dialog_cloud_unittest.cc

index a03942bf8e951e1f8e6e3e5670ec14b9d36b25d9..da516569e9d293bbd50b204f4bae4e151e3385ff 100644

--- a/chrome/browser/printing/print_dialog_cloud_unittest.cc

+++ b/chrome/browser/printing/print_dialog_cloud_unittest.cc

@@ -300,7 +300,7 @@ TEST_F(CloudPrintHtmlDialogDelegateTest, BasicChecks) {

EXPECT_TRUE(delegate_->IsDialogModal());

EXPECT_THAT(delegate_->GetDialogContentURL().spec(),

StrEq(chrome::kCloudPrintResourcesURL));

- EXPECT_THAT(delegate_->GetDialogTitle(), HasSubstr(L"Print"));

+ EXPECT_TRUE(delegate_->GetDialogTitle().empty());

bool close_dialog = false;

delegate_->OnCloseContents(NULL, &close_dialog);

« no previous file with comments | « chrome/browser/printing/print_dialog_cloud.cc ('k') | no next file » | no next file with comments »