Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: src/api.cc

Issue 4146006: Make Parser class have no friends and fewer things to depend on it. (Closed)
Patch Set: Addressed review comments. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1137 matching lines...) Expand 10 before | Expand all | Expand 10 after
1148 } 1148 }
1149 Utils::OpenHandle(this)->set_internal_field_count(i::Smi::FromInt(value)); 1149 Utils::OpenHandle(this)->set_internal_field_count(i::Smi::FromInt(value));
1150 } 1150 }
1151 1151
1152 1152
1153 // --- S c r i p t D a t a --- 1153 // --- S c r i p t D a t a ---
1154 1154
1155 1155
1156 ScriptData* ScriptData::PreCompile(const char* input, int length) { 1156 ScriptData* ScriptData::PreCompile(const char* input, int length) {
1157 unibrow::Utf8InputBuffer<> buf(input, length); 1157 unibrow::Utf8InputBuffer<> buf(input, length);
1158 return i::Parser::PreParse(i::Handle<i::String>(), &buf, NULL); 1158 return i::ParserApi::PreParse(i::Handle<i::String>(), &buf, NULL);
1159 } 1159 }
1160 1160
1161 1161
1162 ScriptData* ScriptData::PreCompile(v8::Handle<String> source) { 1162 ScriptData* ScriptData::PreCompile(v8::Handle<String> source) {
1163 i::Handle<i::String> str = Utils::OpenHandle(*source); 1163 i::Handle<i::String> str = Utils::OpenHandle(*source);
1164 return i::Parser::PreParse(str, NULL, NULL); 1164 return i::ParserApi::PreParse(str, NULL, NULL);
1165 } 1165 }
1166 1166
1167 1167
1168 ScriptData* ScriptData::New(const char* data, int length) { 1168 ScriptData* ScriptData::New(const char* data, int length) {
1169 // Return an empty ScriptData if the length is obviously invalid. 1169 // Return an empty ScriptData if the length is obviously invalid.
1170 if (length % sizeof(unsigned) != 0) { 1170 if (length % sizeof(unsigned) != 0) {
1171 return new i::ScriptDataImpl(); 1171 return new i::ScriptDataImpl();
1172 } 1172 }
1173 1173
1174 // Copy the data to ensure it is properly aligned. 1174 // Copy the data to ensure it is properly aligned.
(...skipping 3818 matching lines...) Expand 10 before | Expand all | Expand 10 after
4993 4993
4994 4994
4995 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) { 4995 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) {
4996 HandleScopeImplementer* thread_local = 4996 HandleScopeImplementer* thread_local =
4997 reinterpret_cast<HandleScopeImplementer*>(storage); 4997 reinterpret_cast<HandleScopeImplementer*>(storage);
4998 thread_local->IterateThis(v); 4998 thread_local->IterateThis(v);
4999 return storage + ArchiveSpacePerThread(); 4999 return storage + ArchiveSpacePerThread();
5000 } 5000 }
5001 5001
5002 } } // namespace v8::internal 5002 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698