Issue 4144002: gclient can now handle git URLs containing "-" in usernames and "~" in paths....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4144002: gclient can now handle git URLs containing "-" in usernames and "~" in paths.... (Closed)

Created:
10 years, 1 month ago by torsten

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, M-A Ruel

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

gclient can now handle git URLs containing "-" in usernames and "~" in paths. Contributed by Torsten Becker <torsten.becker@gmail.com>; BUG= TEST=gclient config 'ssh://user-name@asd.com/~/asd.git' && gclient sync # fails in SplitUrlRevision Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63877

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	gclient_utils.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/gclient_utils_test.py	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

torsten

Hi, I found that gclient crashed when trying to sync dependencies with git URLs which ...

10 years, 1 month ago (2010-10-26 10:27:26 UTC) #1

lgtm, committed as r63877.