Issue 4143005: Roll new (r2528) ThreadSanitizer binaries for Linux (x86/x64) and Mac (10.5/1...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4143005: Roll new (r2528) ThreadSanitizer binaries for Linux (x86/x64) and Mac (10.5/1... (Closed)

Created:
10 years, 1 month ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/

Visibility:
Public.

Description

Roll new (r2528) ThreadSanitizer binaries for Linux (x86/x64) and Mac (10.5/10.6) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64212

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -8 lines)			Patch
M	binaries/linux_x64/bin/valgrind-tsan.sh	View	Binary file		0 comments	Download
M	binaries/linux_x86/bin/valgrind-tsan.sh	View	Binary file		0 comments	Download
M	binaries/mac/bin/valgrind-tsan.sh	View	Binary file		0 comments	Download
M	binaries/mac_10.6/bin/valgrind-tsan.sh	View	Binary file		0 comments	Download
M	scripts/build-tsan-for-chromium.sh	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	scripts/common.sh	View	1 chunk	+0 lines, -6 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

LGTM Please make the TSan/wf green before cooking binaries -> Mac is hanging now, right? ...

10 years, 1 month ago (2010-10-29 09:05:28 UTC) #2

Timur Iskhodzhanov

http://codereview.chromium.org/4143005/diff/1/7 File scripts/common.sh (left): http://codereview.chromium.org/4143005/diff/1/7#oldcode39 scripts/common.sh:39: patch -p0 -i "${THISDIR}/intercept_tcmalloc.patch" Don't you need to still ...

10 years, 1 month ago (2010-10-29 09:06:10 UTC) #3

Alexander Potapenko

10 years, 1 month ago (2010-10-29 11:43:01 UTC) #4

Regarding Mac failures -- they were related to the tests, not Valgrind or TSan.

http://codereview.chromium.org/4143005/diff/1/7
File scripts/common.sh (left):

http://codereview.chromium.org/4143005/diff/1/7#oldcode39
scripts/common.sh:39: patch -p0 -i "${THISDIR}/intercept_tcmalloc.patch"
On 2010/10/29 09:06:10, Timur Iskhodzhanov wrote:
> Don't you need to still apply this for Memcheck?

This function builds valgrind-variant, which already contains this patch. We
don't use it to build Memcheck, however.

Expand Messages | Collapse Messages