Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 4142013: CHROMIUMOS: wpa_supplicant: Back off short scan interval after a number of attempts (Closed)

Created:
10 years, 1 month ago by Paul Stewart
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/hostap.git
Visibility:
Public.

Description

CHROMIUMOS: wpa_supplicant: Back off short scan interval after a number of attempts The short scan interval is engaged when the received signal intensity is (or becomes) lower than our threshold. It is used to quickly scan to find an available place to roam to. This CL adds the behavior of "giving up" on a quick roam after a few scan attempts, and reverting to the slow scan interval. This slows down scans again and preserves battery in situations where there all the options are bad (or where there is only one AP and you are stationary in a bad reception zone). Sameer, you may want to test this change as well. BUG=chromium-os:6408 TEST=Manual -- join a singleton access point, go to the edge of the network, watch /var/log/messages and confirm scans. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6f9b705

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused define #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M wpa_supplicant/bgscan_delta.c View 1 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 1 month ago (2010-10-29 19:35:07 UTC) #1
Sam Leffler
10 years, 1 month ago (2010-10-29 20:26:38 UTC) #2
LGTM modulo nits; no need for a roundtrip

http://codereview.chromium.org/4142013/diff/1/2
File wpa_supplicant/bgscan_delta.c (right):

http://codereview.chromium.org/4142013/diff/1/2#newcode27
wpa_supplicant/bgscan_delta.c:27: #define BGSCAN_DELTA_MAX_SHORT_SCANS 6
looks unused

http://codereview.chromium.org/4142013/diff/1/2#newcode34
wpa_supplicant/bgscan_delta.c:34: int short_scan_count; /* counter for scans
using short scan interval */
consecutive scans

Powered by Google App Engine
This is Rietveld 408576698