Issue 414037: Merge 32560 - [Mac] Add support for growing or shrinking the window during an...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 414037: Merge 32560 - [Mac] Add support for growing or shrinking the window during an... (Closed)

Created:
11 years, 1 month ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Merge 32560 - [Mac] Add support for growing or shrinking the window during animations. BUG=http://crbug.com/14900 TEST=No visible impact, yet. Review URL: http://codereview.chromium.org/391035 TBR=rohitrao@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32618

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+174 lines, -44 lines)			Patch
M	chrome/browser/cocoa/bookmark_bar_controller.mm	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View	8 chunks	+94 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller_unittest.mm	View	5 chunks	+65 lines, -8 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.mm	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller_unittest.mm	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

11 years, 1 month ago (2009-11-20 18:56:57 UTC) #3

On 2009/11/20 17:42:07, rohitrao wrote:
> LGTM.  Thanks for merging!

No prob -- it's really easy with drover (assuming no conflicts).