Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: src/log.h

Issue 414036: Reimplement logging of API callbacks entry points in an easier way. (Closed)
Patch Set: Final version Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index 6570c74632dab75fb819c64b5e56d761188ad2c3..091566e57800d104ee5885e8f9394a3262989652 100644
--- a/src/log.h
+++ b/src/log.h
@@ -202,8 +202,7 @@ class Logger {
// ==== Events logged by --log-code. ====
// Emits a code event for a callback function.
- static void CallbackEvent(const char* class_name, const char* method_name,
- Address entry_point);
+ static void CallbackEvent(String* name, Address entry_point);
// Emits a code create event.
static void CodeCreateEvent(LogEventsAndTags tag,
Code* code, const char* source);
@@ -271,10 +270,6 @@ class Logger {
static void LogCompiledFunctions();
// Used for logging stubs found in the snapshot.
static void LogCodeObject(Object* code_object);
- // Used for logging callback entry points to be able to reveal their
- // names in call stacks when information about native code exports is
- // inaccessible.
- static void LogCallbacks();
private:
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698