Issue 414036: Reimplement logging of API callbacks entry points in an easier way.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 414036: Reimplement logging of API callbacks entry points in an easier way. (Closed)

Created:
11 years, 1 month ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Reimplement logging of API callbacks entry points in an easier way. Now they are logging during "LogCompiledFunctions" cycle. API functions are detected by examining SFI's "function_data" field. Committed: http://code.google.com/p/v8/source/detail?r=3343

Patch Set 1 #

Total comments: 1

Patch Set 2 : Final version #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -94 lines)			Patch
M	src/log.h	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	src/log.cc	View	1	4 chunks	+37 lines, -85 lines	0 comments	Download
M	test/cctest/test-log.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 1 month ago (2009-11-23 08:45:38 UTC) #2

LGTM

http://codereview.chromium.org/414036/diff/1/4
File test/cctest/test-log.cc (right):

http://codereview.chromium.org/414036/diff/1/4#newcode528
test/cctest/test-log.cc:528: *(pos + strlen(ref_data.start())) = '\0';
Missing indent.

Expand Messages | Collapse Messages