Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 414033: Change the signature for StrNDup to match the implementation. This... (Closed)

Created:
11 years, 1 month ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change the signature for StrNDup to match the implementation. This mismatch causes problems if attempting to build d8 with readline support. Committed: http://code.google.com/p/v8/source/detail?r=3342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/allocation.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 1 month ago (2009-11-20 12:58:23 UTC) #1
Søren Thygesen Gjesse
11 years, 1 month ago (2009-11-20 13:07:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698