Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 414022: Fix assert in sad_tab when requested width for message is < -1. (Closed)

Created:
11 years, 1 month ago by kuan
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Fix assert in sad_tab when requested width for message is < -1. BUG=28270 TEST=verify per bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32595

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/gtk/sad_tab_gtk.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kuan
11 years, 1 month ago (2009-11-20 02:09:08 UTC) #1
Evan Stade
http://codereview.chromium.org/414022/diff/1/2 File chrome/browser/gtk/sad_tab_gtk.cc (right): http://codereview.chromium.org/414022/diff/1/2#newcode173 Line 173: std::max(width_ - (kTabHorzMargin * 2), -1), -1); I ...
11 years, 1 month ago (2009-11-20 02:15:02 UTC) #2
kuan
i've made the change to only set size if width is > -1. pls take ...
11 years, 1 month ago (2009-11-20 02:36:46 UTC) #3
Evan Stade
11 years, 1 month ago (2009-11-20 02:43:35 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698