Issue 4139011: crash-reporter: fix bug where we were sending "undefined" as all stack signatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4139011: crash-reporter: fix bug where we were sending "undefined" as all stack signatures (Closed)

Created:
10 years, 1 month ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov, oshima

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/crash-reporter.git@master

Visibility:
Public.

Description

crash-reporter: fix bug where we were sending "undefined" as all stack signatures Also, move the logic for picking which extra parameters to send up above where mock sending ends so UserCrash detects this regression in the future. And merge unknown and undefined special strings into one to avoid confusion. Change-Id: Ic55a0c5b473a0cef39eac2c1250d1607deffe050 BUG=8266 TEST=User/KernelCrash and CrashSender Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0ccfda8

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
	M	crash_sender	View		5 chunks	+17 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

10 years, 1 month ago (2010-11-01 21:07:31 UTC) #3

looks like wrong bug id (and site). can you update?

On 2010/11/01 19:42:26, petkov wrote:
> LGTM

Expand Messages | Collapse Messages