Issue 4139007: Tegra2: spi: move spi_init up to board_init so UART works OK when loading from SPI flash chip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4139007: Tegra2: spi: move spi_init up to board_init so UART works OK when loading from SPI flash chip (Closed)

Created:
10 years, 1 month ago by Tom Warren

Modified:
9 years, 7 months ago

Reviewers:
robotboy, jimmyz.nvidia

CC:
chromium-os-reviews_chromium.org, dneiss, Olof Johansson, chromeboy, amoljadi

Base URL:
http://git.chromium.org/git/u-boot

Visibility:
Public.

Description

Tegra2: spi: move spi_init up to board_init so UART works OK when loading from SPI flash chip Signed-off-by: Tom Warren <twarren@nvidia.com>; Only when a BCT/U-Boot.bin image is flashed to SPI and booted, the console output was corrupted. This was because the spi_init() proc wasn't running early enough in POST, and the GPIO UART_DISABLE wasn't being gated. BUG=none TEST=Create flashable image w/buildimage, write it to SPI, and reset/restart. No console corruption seen via serial. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=09eada4

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	board/tegra2/common/board.c	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks.  I'll commit now.

Expand Messages | Collapse Messages