Issue 4137003: Print last 200 lines of update_engine.log from failed update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4137003: Print last 200 lines of update_engine.log from failed update. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Print last 200 lines of update_engine.log from failed update. Change-Id: I0dbc760007038086b94d534d497a7f72b957f365 BUG= TEST=Ran it on a failed update. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3b39a54

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	image_to_live.sh	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 1 month ago (2010-10-26 19:09:55 UTC) #2

LGTM

On Mon, Oct 25, 2010 at 7:40 PM,  <sosa@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Print last 200 lines of update_engine.log from failed update.
>
> Change-Id: I0dbc760007038086b94d534d497a7f72b957f365
>
> BUG=
> TEST=Ran it on a failed update.
>
> Please review this at http://codereview.chromium.org/4137003/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M image_to_live.sh
>
>
> Index: image_to_live.sh
> diff --git a/image_to_live.sh b/image_to_live.sh
> index
>
6329cafc2f93b66dbd3e3816d4a31311e3682d6e..41c32e0d8817bf1e0de1f4dceabd5b84d4f1e0fe
> 100755
> --- a/image_to_live.sh
> +++ b/image_to_live.sh
> @@ -346,6 +346,8 @@ function main() {
>   fi
>
>   if [ ${FLAGS_update} -eq ${FLAGS_TRUE} ] && ! run_auto_update; then
> +    warn "Dumping update_engine.log for debugging and/or bug reporting."
> +    tail -n 200 "${FLAGS_update_log}" >&2
>     die "Update was not successful."
>   fi
>
>
>
>

Expand Messages | Collapse Messages