Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: remoting/host/simple_host_process.cc

Issue 4136010: Cleanups in the video encoding decoding code. Reenable VP8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed arm build Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/session_manager_unittest.cc ('k') | remoting/proto/chromotocol.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/simple_host_process.cc
diff --git a/remoting/host/simple_host_process.cc b/remoting/host/simple_host_process.cc
index d998ef9c335bf4ffe8c6a57bd127c23eca2d4239..2733850821b36aa5d0a901c6a5e5a103289752e1 100644
--- a/remoting/host/simple_host_process.cc
+++ b/remoting/host/simple_host_process.cc
@@ -25,14 +25,18 @@
#include "base/logging.h"
#include "base/mac/scoped_nsautorelease_pool.h"
#include "base/nss_util.h"
+#include "base/path_service.h"
#include "base/thread.h"
+#include "media/base/media.h"
#include "remoting/base/encoder_verbatim.h"
+#include "remoting/base/encoder_vp8.h"
#include "remoting/base/encoder_zlib.h"
+#include "remoting/base/tracer.h"
#include "remoting/host/capturer_fake.h"
#include "remoting/host/chromoting_host.h"
#include "remoting/host/chromoting_host_context.h"
#include "remoting/host/json_host_config.h"
-#include "remoting/base/tracer.h"
+#include "remoting/proto/video.pb.h"
#if defined(OS_WIN)
#include "remoting/host/capturer_gdi.h"
@@ -62,6 +66,7 @@ void ShutdownTask(MessageLoop* message_loop) {
const std::string kFakeSwitchName = "fake";
const std::string kConfigSwitchName = "config";
const std::string kVerbatimSwitchName = "verbatim";
+const std::string kVp8SwitchName = "vp8";
int main(int argc, char** argv) {
// Needed for the Mac, so we don't leak objects when threads are created.
@@ -92,14 +97,15 @@ int main(int argc, char** argv) {
// Check the argument to see if we should use a fake capturer and encoder.
bool fake = cmd_line->HasSwitch(kFakeSwitchName);
bool verbatim = cmd_line->HasSwitch(kVerbatimSwitchName);
+ bool vp8 = cmd_line->HasSwitch(kVp8SwitchName);
#if defined(OS_WIN)
- std::wstring path = GetEnvironmentVar(kHomeDrive);
- path += GetEnvironmentVar(kHomePath);
+ std::wstring home_path = GetEnvironmentVar(kHomeDrive);
+ home_path += GetEnvironmentVar(kHomePath);
#else
- std::string path = GetEnvironmentVar(base::env_vars::kHome);
+ std::string home_path = GetEnvironmentVar(base::env_vars::kHome);
#endif
- FilePath config_path(path);
+ FilePath config_path(home_path);
config_path = config_path.Append(kDefaultConfigPath);
if (cmd_line->HasSwitch(kConfigSwitchName)) {
config_path = cmd_line->GetSwitchValuePath(kConfigSwitchName);
@@ -116,6 +122,14 @@ int main(int argc, char** argv) {
encoder.reset(new remoting::EncoderVerbatim());
}
+ // TODO(sergeyu): Enable VP8 on ARM builds.
+#if !defined(ARCH_CPU_ARM_FAMILY)
+ if (vp8) {
+ LOG(INFO) << "Using the verbatim encoder.";
+ encoder.reset(new remoting::EncoderVp8());
+ }
+#endif
+
base::Thread file_io_thread("FileIO");
file_io_thread.Start();
@@ -132,6 +146,11 @@ int main(int argc, char** argv) {
remoting::ChromotingHostContext context;
context.Start();
+ FilePath module_path;
+ PathService::Get(base::DIR_MODULE, &module_path);
+ CHECK(media::InitializeMediaLibrary(module_path))
+ << "Cannot load media library";
+
// Construct a chromoting host.
scoped_refptr<remoting::ChromotingHost> host(
new remoting::ChromotingHost(&context,
« no previous file with comments | « remoting/host/session_manager_unittest.cc ('k') | remoting/proto/chromotocol.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698