Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9466)

Unified Diff: chrome/renderer/render_view.cc

Issue 4136004: Track in which frames navigation errors occurred and don't send further navigation events for them (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/extensions
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index 2b1615d021f457df88e1ed4dc211ca9bdf4699ba..87a2f2441db4d758f1d4303e3989de69dc6f5413 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -298,7 +298,6 @@ static const int kDelaySecondsForContentStateSync = 1;
// The maximum number of popups that can be spawned from one page.
static const int kMaximumNumberOfUnacknowledgedPopups = 25;
-static const char kUnreachableWebDataURL[] = "chrome://chromewebdata/";
static const char kBackForwardNavigationScheme[] = "history";
static void GetRedirectChain(WebDataSource* ds, std::vector<GURL>* result) {
@@ -1632,7 +1631,7 @@ void RenderView::LoadNavigationErrorPage(WebFrame* frame,
}
frame->loadHTMLString(alt_html,
- GURL(kUnreachableWebDataURL),
+ GURL(chrome::kChromeUnreachableWebDataURL),
failed_url,
replace);
}
@@ -4776,7 +4775,7 @@ bool RenderView::MaybeLoadAlternateErrorPage(WebFrame* frame,
// Load an empty page first so there is an immediate response to the error,
// and then kick off a request for the alternate error page.
frame->loadHTMLString(std::string(),
- GURL(kUnreachableWebDataURL),
+ GURL(chrome::kChromeUnreachableWebDataURL),
error.unreachableURL,
replace);

Powered by Google App Engine
This is Rietveld 408576698