Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: chrome/browser/chromeos/cros/cros_mock.cc

Issue 4136002: Add 3G Activation to the network menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added else {} Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/status/network_menu.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/cros_mock.cc
diff --git a/chrome/browser/chromeos/cros/cros_mock.cc b/chrome/browser/chromeos/cros/cros_mock.cc
index ab33dc0344ff2671381160d7c850fa610e8efbd8..e812d7525919d98e3cb82241b0485c1a53f48737 100644
--- a/chrome/browser/chromeos/cros/cros_mock.cc
+++ b/chrome/browser/chromeos/cros/cros_mock.cc
@@ -274,7 +274,7 @@ void CrosMock::SetNetworkLibraryStatusAreaExpectations() {
// NetworkDropdownButton::NetworkChanged() calls:
EXPECT_CALL(*mock_network_library_, ethernet_connected())
- .Times(2) // also called by NetworkMenu::InitMenuItems()
+ .Times(1)
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, wifi_connected())
@@ -294,7 +294,7 @@ void CrosMock::SetNetworkLibraryStatusAreaExpectations() {
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, Connected())
- .Times(2) // also called by NetworkMenu::InitMenuItems()
+ .Times(1)
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, Connecting())
@@ -303,29 +303,21 @@ void CrosMock::SetNetworkLibraryStatusAreaExpectations() {
.RetiresOnSaturation();
// NetworkMenu::InitMenuItems() calls:
- EXPECT_CALL(*mock_network_library_, ethernet_connecting())
- .Times(1)
- .WillRepeatedly((Return(false)))
- .RetiresOnSaturation();
- EXPECT_CALL(*mock_network_library_, wifi_networks())
+ EXPECT_CALL(*mock_network_library_, ethernet_available())
.Times(1)
- .WillRepeatedly((ReturnRef(wifi_networks_)))
+ .WillRepeatedly((Return(true)))
.RetiresOnSaturation();
- EXPECT_CALL(*mock_network_library_, wifi_available())
+ EXPECT_CALL(*mock_network_library_, ethernet_connected())
.Times(1)
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
- EXPECT_CALL(*mock_network_library_, wifi_network())
- .Times(1)
- .WillRepeatedly((ReturnRef(wifi_network_)))
- .RetiresOnSaturation();
- EXPECT_CALL(*mock_network_library_, cellular_networks())
+ EXPECT_CALL(*mock_network_library_, ethernet_connecting())
.Times(1)
- .WillRepeatedly((ReturnRef(cellular_networks_)))
+ .WillRepeatedly((Return(false)))
.RetiresOnSaturation();
- EXPECT_CALL(*mock_network_library_, cellular_network())
+ EXPECT_CALL(*mock_network_library_, wifi_available())
.Times(1)
- .WillRepeatedly((ReturnRef(cellular_network_)))
+ .WillRepeatedly((Return(false)))
.RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, cellular_available())
.Times(1)
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/status/network_menu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698