Issue 4135004: Separate JSON parsing from the JavaScript parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4135004: Separate JSON parsing from the JavaScript parser. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Separate JSON parsing from the JavaScript parser. Switch JSON parsing to creating the value directly instead of createing code to create the value.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename GetSymbol. Move ZoneScope. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -250 lines)			Patch
M	src/compiler.h	View		5 chunks	+3 lines, -12 lines	0 comments	Download
M	src/compiler.cc	View		4 chunks	+6 lines, -21 lines	0 comments	Download
M	src/debug-debugger.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/json.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/parser.h	View	1	3 chunks	+43 lines, -24 lines	0 comments	Download
M	src/parser.cc	View	1	3 chunks	+120 lines, -154 lines	0 comments	Download
M	src/runtime.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	src/runtime.cc	View		4 chunks	+20 lines, -12 lines	0 comments	Download
M	src/scanner.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/v8natives.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/debug-compile-event.js	View		5 chunks	+3 lines, -15 lines	0 comments	Download
M	test/mjsunit/mirror-script.js	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

10 years, 1 month ago (2010-10-27 09:11:42 UTC) #3

http://codereview.chromium.org/4135004/diff/1/7
File src/parser.cc (right):

http://codereview.chromium.org/4135004/diff/1/7#newcode4292
src/parser.cc:4292: Handle<String> JsonParser::GetSymbol() {
Good point. Will rename to GetString().

Expand Messages | Collapse Messages