Issue 4134013: [cros] Possible fix for crash - check whether LoginPerformer instance needs to be recreated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4134013: [cros] Possible fix for crash - check whether LoginPerformer instance needs to be recreated. (Closed)

Created:
10 years, 1 month ago by Nikita (slow)

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[cros] Possible fix for crash - check whether LoginPerformer instance exists. BUG=chromium-os:8282 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69124

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 7 (0 generated)

Nikita (slow)

Ok, this wouldn't work because Authenticator instance caches state of current user (like username).

10 years, 1 month ago (2010-11-01 15:16:12 UTC) #3

Dmitry Polukhin

LGTM But because we are not sure how we get to this state perhaps it ...

10 years, 1 month ago (2010-11-02 13:29:59 UTC) #5

LGTM