Mac: Allow accessing various files needed by the defaults system.

Mac: Allow statting various files needed for use by the defaults system.

This CL allows statting the following files:
1) '/'
2) '/var'

And full read access for various paths where .GlobalPreferences.plist may be present.

The first 2 seem harmless to unblock and the 3rd is used by the default system.

Bug=60917
TEST=Repro steps in bug.
Cleanup: Remove stale TODO

The code in question is no longer needed since Skia has changed to remove the #define in question.

BUG=None
TEST=Compilation shouldn't break

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65331

[jeremy, 2010-10-28 12:42:33]

Please ignore the change to l10n_util.cc

[Mark Mentovai, 2010-10-28 16:35:07]

http://codereview.chromium.org/4134007/diff/2001/3002
File chrome/common/sandbox_mac.mm (right):

http://codereview.chromium.org/4134007/diff/2001/3002#newcode122
chrome/common/sandbox_mac.mm:122: // Note: If str_utf8 contains any characters <
32 || >125 then the function
Will we now fall down for home directories with funny characters in them?

Previously, it was pretty safe to assume we’d only call this function for system
paths, and we pretty much knew that they’d be ASCII. We weren’t quoting the home
directory before, though, and that’s more in the user’s control.

http://codereview.chromium.org/4134007/diff/2001/3002#newcode454
chrome/common/sandbox_mac.mm:454: &home_dir_escaped_for_literal)) {
It’s preferable to align arguments vertically if they fit. Put the & under the h
from the line above.

http://codereview.chromium.org/4134007/diff/2001/3003
File chrome/common/sandbox_mac_diraccess_unittest.mm (right):

http://codereview.chromium.org/4134007/diff/2001/3003#newcode27
chrome/common/sandbox_mac_diraccess_unittest.mm:27: bool add_directory_suffix,
Can you add a test to exercise add_directory_suffix?

http://codereview.chromium.org/4134007/diff/2001/3003#newcode107
chrome/common/sandbox_mac_diraccess_unittest.mm:107: true, &out));
Same thing on the alignment.

http://codereview.chromium.org/4134007/diff/2001/3004
File chrome/renderer/renderer.sb (right):

http://codereview.chromium.org/4134007/diff/2001/3004#newcode31
chrome/renderer/renderer.sb:31: 
Blank line at EOF.

[jeremy, 2010-11-03 14:58:37]

New version uploaded rebased on top of my previous CLs, it's now tiny.

I experimented with refactoring our regex escaping code but when I started
writing more complex tests I ran into all kinds of incompatibilities in corner
cases between 10.5 & 10.6 regex syntax.  Upon closer inspection, looks like this
fix works fine without the bla/.GlobalPreferences.\d+.plist files.

Next time we run into a case where regex escaping of arbitrary strings is needed
I'll dust off the code and try to squeeze out the corner cases.  With the recent
refactor this is now much easier to do.

[Mark Mentovai, 2010-11-04 16:09:46]

LGTM

[jeremy, 2010-11-07 05:48:58]

Could you take another look.

I changed this to allow read access to .GlobalPreferences and removed a stale 
comment.  Landed as is since I didn't want to leave this bug on trunk any
longer.

[Mark Mentovai, 2010-11-08 20:45:26]

OK