Issue 4132005: Kill Extension::RuntimeData and move its guts to ExtensionsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4132005: Kill Extension::RuntimeData and move its guts to ExtensionsService. (Closed)

Created:
10 years, 1 month ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, ncarter (slow), idana, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, jam, pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Kill Extension::RuntimeData and move its guts to ExtensionsService. ImageCache remains on Extension, on the expectation that it will eventually be loaded at startup. BUG=56558 TEST=no functional change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64973

Patch Set 1 #

Patch Set 2 : oops #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -87 lines)			Patch
M	chrome/browser/extensions/extension_host.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View		3 chunks	+30 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	1	6 chunks	+39 lines, -3 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		3 chunks	+9 lines, -41 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1	5 chunks	+9 lines, -37 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages