Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 4131005: AU: Push seeks in http fetching to the progress percentage. (Closed)

Created:
10 years, 1 month ago by adlr
Modified:
9 years ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Push seeks in http fetching to the progress percentage. The updater was reporting status as a fraction of bytes downloaded vs total, ignoring any bytes that were skipped due to resuming an upload. The result was that a user may see progress go from 0 to 60 percent, then reboot, then see progress go from 0 to 40 percent, then finish. This CL allows an HTTP fetcher to report to the delegate that it's seeking to a particular offset. BUG=8151 TEST=applied updates on the machine; unittest Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=34e41a1

Patch Set 1 #

Patch Set 2 : fix un-commented things from debugging; mode fix #

Total comments: 2

Patch Set 3 : fix for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -13 lines) Patch
M download_action.h View 1 chunk +1 line, -0 lines 0 comments Download
M download_action.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M download_action_unittest.cc View 5 chunks +26 lines, -8 lines 0 comments Download
M http_fetcher.h View 1 chunk +4 lines, -2 lines 0 comments Download
M mock_http_fetcher.h View 1 chunk +5 lines, -1 line 0 comments Download
M multi_http_fetcher.h View 2 chunks +4 lines, -1 line 0 comments Download
M prefs.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
adlr
10 years, 1 month ago (2010-10-26 17:07:11 UTC) #1
petkov
LGTM w/ a suggestion. I guess this is much easier than reporting the number of ...
10 years, 1 month ago (2010-10-26 17:28:43 UTC) #2
adlr
10 years, 1 month ago (2010-10-27 02:59:55 UTC) #3
fixed. pushing...

http://codereview.chromium.org/4131005/diff/2001/3007
File prefs.cc (right):

http://codereview.chromium.org/4131005/diff/2001/3007#newcode40
prefs.cc:40: LOG(ERROR) << "Unable to read prefs from " << filename.value()
On 2010/10/26 17:28:44, petkov wrote:
> Use PLOG instead? Also, I'd change it to a warning to not freak out random
> people looking at logs.
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698